Fix MATH readme

[hiyuchang]

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

• Code has passed all tests
• Docstrings have been added/updated in Google Style
• Documentation has been updated
• Code is ready for review

[gemini-code-assist]

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the documentation for the grpo_math example to accurately reflect the current framework and dataset structure. It also includes a minor code adjustment to align with a new pattern for accessing unique identifiers within the reward function utility.

Highlights

• Documentation Update: The README.md for the grpo_math example has been updated to reflect the use of GRPO instead of PPO. It now references the RM-Gallery framework, includes installation instructions for it, and provides a clear jsonl snippet illustrating the expected dataset format.
• Code Refinement: In trinity/common/rewards/reward_fn.py, the way unique_id is accessed for DataSample creation has been updated from experience.unique_id to experience.eid.uid. This change likely aligns with an internal restructuring of how entity IDs are managed or retrieved.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the README for the GRPO MATH example to align it with the GRPO algorithm and adds details on the expected dataset format. It also includes a necessary bug fix in the reward function. My review includes a couple of suggestions for the README to correct a typo and ensure the provided jsonl example is valid, which will improve clarity for users.