Skip to content

Conversation

@hiyuchang
Copy link
Collaborator

@hiyuchang hiyuchang commented Jul 16, 2025

Description

As the title says.

  1. Newly added parameters are fsdp_config.forward_prefetch: false, actor.entropy_from_logits_with_chunking: false, and actor.entropy_checkpointing: false.
  2. Remove load_dataset(trust_remote_code=True) to fit the new version of datasets.
  3. Update verl==0.4.1 and vllm=0.9.2

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@hiyuchang hiyuchang requested review from chenyushuo and pan-x-c July 16, 2025 06:21
Copy link
Collaborator

@yanxi-chen yanxi-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pan-x-c pan-x-c merged commit 15f8a8b into modelscope:main Jul 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants