Skip to content

Conversation

@thaJeztah
Copy link
Member

- Description for the changelog

libnetwork/iptables: deprecate Passthrough. This function was only used internally, and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Dec 16, 2024
@thaJeztah thaJeztah self-assigned this Dec 16, 2024
@akerouanton
Copy link
Member

We consider libnetwork as an internal subsystem despite not being under internal/. Should we really mention that change in the changelog?

@thaJeztah
Copy link
Member Author

I think I found some network-plugins importing this package, so it's mostly a precaution. We can decide to only mention these on GitHub release-notes, and no in the release-notes on docs.docker.com

@vvoland
Copy link
Contributor

vvoland commented Dec 17, 2024

(But personally, I wouldn't mind just ripping it out without deprecation notice either)

@thaJeztah
Copy link
Member Author

Yeah, I think in most cases, people using things inside libnetwork/ would have a hard time. That said; separation is a bit fuzzy as there are parts that are used, e.g. BuildKit depending on the resolvconf code; https://github.com/moby/buildkit/tree/4ea0679ee36557dd1249ec5b6cd3c88f39d81464/vendor/github.com/docker/docker/libnetwork

We should look at making the separation clearer. I could backport it to 27.x, then rip it out in master I guess

@thaJeztah
Copy link
Member Author

I opened this PR for consideration; with that (and the plan to do a v27.5.0), I think we can remove both from master after that;

@thaJeztah thaJeztah merged commit 8d3ecc2 into moby:master Dec 17, 2024
161 checks passed
@thaJeztah thaJeztah deleted the libnetwork_deprecate_Passthrough branch December 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants