Skip to content

Track resource limit and throw if exceeded - #1718

Merged
awni merged 1 commit into
mainfrom
track_resource_limit
Dec 19, 2024
Merged

awni merged 1 commit into
mainfrom
track_resource_limit

Conversation

@awni

@awni awni commented Dec 18, 2024 •

Copy link
Copy Markdown
Member

Track the metal resource limit iogpu.rsrc_limit and throw if it is exceeded. mx.metal.device_info also returns the resource limit.

Closes #1712

@awni
awni force-pushed the track_resource_limit branch from 949ae45 to 4140185 Compare December 18, 2024 15:42
@awni
awni requested review from angeloskath and barronalex and removed request for barronalex December 18, 2024 15:43

@angeloskath angeloskath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@awni
awni merged commit 7480059 into main Dec 19, 2024
@awni
awni deleted the track_resource_limit branch December 19, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Lack of error reporting when unevaluated graph becomes too big

2 participants