This repository was archived by the owner on Nov 2, 2024. It is now read-only.
Use Highlight.php instead of Prism.js for server-side rendering of Code block's syntax highlighting#13
Closed
westonruter wants to merge 9 commits intomkaz:masterfrom
Closed
Conversation
|
Tested it today, works really well. Thanks @westonruter for the contribution! |
Owner
|
I really appreciate the effort you put in for this, but I'm going to keep this plugin as front-end only using Prism. For a server-side rendering plugin, please feel free to fork from this PR, if you do let me know and I can add a link in the readme for the alternate implementation. I just want to keep this fairly low maintenance and simple, the less things in it the less likely it will break down the line; the reason I did #23 and removing build and other steps, fewer dependencies and moving parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots: