Skip to content

fix: keep one pest alive when the reserved pest is vacuumed - #163

Open
zoeedevs wants to merge 342 commits into
mizly:devfrom
zoeedevs:fix/leave-one-reserved-pest
Open

zoeedevs wants to merge 342 commits into
mizly:devfrom
zoeedevs:fix/leave-one-reserved-pest

Conversation

@zoeedevs

Copy link
Copy Markdown
Contributor

Problem

With Leave One Pest Alive, the macro preselects the most-isolated pest to spare and kills N-1 on the plot. But the kill budget only decrements on intended target kills. When the spared (reserved) pest gets caught in the vacuum aimed at a neighbor and dies, nothing notices — so the macro spends its full budget on the rest and leaves the plot with 0 pests instead of 1.

Fix

Each tick (PestDestroyer.update → PestLeaveOneController.tryHandleLostReservedPest) the reserved pest's liveness is confirmed (checked against killedEntities and level.getEntity for removed/dead). If it died:

  • spend one kill from the leave-one budget (an extra pest left the plot the budget never counted),
  • drop the reservation so a fresh pest is chosen on the next scan,
  • and if that empties the budget, finish the plot immediately so the current survivor is left alive.

Validation

  • ./gradlew compileJava compileTestJava clean (JDK 25).
  • PestLeaveOneControllerTest passes (added a budget-boundary assertion); full unit suite green aside from a pre-existing CRLF line-ending failure in PreReorgInventoryTest unrelated to this change.
  • In-game verification of the leave-one plots still recommended.

vlensys added 30 commits October 4, 2026 22:08
With no route selected, or one that is missing or has no waypoints, strider fishing walks to the Sawyer spot (-694 120 78) and fishes there. A start close by on Galatea walks straight over; any other start and every restart warps to galatea first. New configs start with no route selected, and route walks now swim up out of lava.
A float that comes down off the lava now rules out both the cell the sim promised and the block the throw was aimed at, and the current look, the last check before the click and every candidate pitch all respect that. The misses are only forgiven once a float settles in the lava or gets a bite, on arriving home and when the origin changes, no longer at every click.
This changes which classic aim wins. The search now tries the cells nearest the player first and takes the first one with a throw that lands with room either side, where it used to pick the roomiest throw across every cell. It only looks at the top of the liquid, traces the float against blocks alone, runs two cells a tick and carries on past the cells it already tried after a miss. Only running out of cells widens the radius and forgives the misses.
vlensys and others added 27 commits October 5, 2026 20:00
# Conflicts:
#	src/main/java/dev/aether/bootstrap/AetherKeybindRegistry.java
feat: orbit gui, an in-world settings menu with a living farm
Aether 1.5: Orbit GUI, fishing macro and the aether-ea work
…, behind a setting, and only rewrite changed pictures
fix: restart while fishing, stuck jump, efficient preset, garden recorder, barn crash, paused saves
Leave-one preselects the most isolated pest to spare and kills N-1, but
the budget only counted intended target kills. When the spared pest was
caught by the vacuum aimed at a neighbor, nothing noticed and the macro
spent its full budget, leaving the plot empty.

Confirm the reserved pest each tick; if it died, spend one budgeted kill
and drop the reservation so a fresh pest is chosen, finishing the plot
immediately when that empties the budget so the current survivor stays.
@mizly
mizly deleted the branch mizly:dev October 30, 2026 05:06
@mizly mizly closed this Oct 30, 2026
@mizly mizly reopened this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants