Skip to content

fix(frontend): applyThemeのstartViewTransitionをエラーハンドリングする#16564

Draft
tamaina wants to merge 1 commit intomisskey-dev:developfrom
tamaina:viewtrans-if
Draft

fix(frontend): applyThemeのstartViewTransitionをエラーハンドリングする#16564
tamaina wants to merge 1 commit intomisskey-dev:developfrom
tamaina:viewtrans-if

Conversation

@tamaina
Copy link
Copy Markdown
Contributor

@tamaina tamaina commented Sep 18, 2025

Fix #16562

What

applyThemeのstartViewTransitionをtry-catchでエラーハンドリングすることで、ブートエラーになるのをやめさせます。

Why

#16562

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 18, 2025
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label Sep 18, 2025
@tamaina tamaina changed the title fix(frontend): applyThemeのstartViewTransitionでエラーハンドリングする fix(frontend): applyThemeのstartViewTransitionをエラーハンドリングする Sep 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.58%. Comparing base (5fe08d0) to head (ecc8686).
⚠️ Report is 566 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/theme.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16564      +/-   ##
===========================================
- Coverage    17.58%   17.58%   -0.01%     
===========================================
  Files          872      872              
  Lines        80438    80445       +7     
  Branches      1339     1339              
===========================================
  Hits         14144    14144              
- Misses       66287    66294       +7     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tamaina tamaina marked this pull request as draft September 18, 2025 12:32
@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Sep 18, 2025

え?これだと直ってないような…(Firefox)

@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Sep 18, 2025

try-catch貫通してそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

iOSで、初回読み込み時確定でエラーになる

1 participant