feat(sw): PWA Web Share Targetでファイルを受け付けるように#16323
Open
tamaina wants to merge 15 commits intomisskey-dev:developfrom
Open
feat(sw): PWA Web Share Targetでファイルを受け付けるように#16323tamaina wants to merge 15 commits intomisskey-dev:developfrom
tamaina wants to merge 15 commits intomisskey-dev:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16323 +/- ##
===========================================
+ Coverage 42.56% 46.03% +3.46%
===========================================
Files 1685 1762 +77
Lines 170650 181687 +11037
Branches 4223 5397 +1174
===========================================
+ Hits 72643 83638 +10995
- Misses 97546 98004 +458
+ Partials 461 45 -416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 |
Member
|
useUploader関数をFileUploaderクラスに書き換えはこっちで再実装するかも |
Contributor
Author
戻した |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #8880
Resolve #14193
What
/sw/shareへの処理を追加share-files-tempに保存する/shareにリダイレクト/shareで、idb-keyvalのshare-files-tempを読んでPostFormのinitialLocalFilesに渡す/shareはハッシュパラメータも受け取るように/shareはクエリ/ハッシュパラメータのfileにDataURIを指定することでファイルを受け取れるように/shareにヘッダーアクションでメニューとして「閉じる」「Misskeyへ」を追加PostFormPropsにinitialLocalFilesを追加MkPostForm.vueでprops.initialLocalFilesがあったらuploader.addFilesするようにWhy
Additional info (optional)
p1.a9z.devで動作中
iOSでは非対応?
PWAを再インストールしないと画像をシェアできないかも
Checklist