Skip to content

enhance(ap): ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加#16297

Open
tamaina wants to merge 77 commits intomisskey-dev:developfrom
tamaina:ap-susp-update
Open

enhance(ap): ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加#16297
tamaina wants to merge 77 commits intomisskey-dev:developfrom
tamaina:ap-susp-update

Conversation

@tamaina
Copy link
Copy Markdown
Contributor

@tamaina tamaina commented Jul 17, 2025

What

  • ApDeliverManagerServiceにaddAllKnowingSharedInboxレシピを追加、UserSuspendServiceで使用するように
  • ApDeliverManagerServiceのunit test追加
  • QueueService.deliverManyの入力のnullを弾くように(ポカよけ)

Why

  • テストを書く
  • addAllKnowingSharedInboxを追加したかった

Additional info (optional)

diff https://github.com/tamaina/misskey/compare/issue16270..ap-susp-update

#16268 に追加しようと思ったけど思ったより大きくなったので単体でPRを出すことにした

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Jul 20, 2025

これmin.node-versionだけ落ちてる?

@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Jul 20, 2025

これ #16284 が原因だ

@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Jul 20, 2025

んあ??

developでも一定確率で落ちてるじゃん(

@tamaina tamaina marked this pull request as ready for review July 23, 2025 18:08
@tamaina tamaina changed the title ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加 ap: ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加 Jul 31, 2025
@tamaina tamaina changed the title ap: ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加 enhance(ap): ApDeliverManagerService: テストを追加、addAllKnowingSharedInbox Recipeを追加 Jul 31, 2025
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Aug 15, 2025

suspend関連の変更も入っている?

@tamaina
Copy link
Copy Markdown
Contributor Author

tamaina commented Aug 15, 2025

Includes and depends on #16284
Includes and depends on #16279

#16268 に追加しようと思ったけど思ったより大きくなったので単体でPRを出すことにした

#16268 のおまけでリファクタしたのを分離してみたやつなのでこれ単体でマージされることをあまり想定してなかったわね

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Aug 15, 2025

ほむん

@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 25, 2025
@KisaragiEffective KisaragiEffective added 🌌Federation The Federation/ActivityPub feature 🧱Blocked Dependant PRs are not merged into target branch labels Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧱Blocked Dependant PRs are not merged into target branch 🌌Federation The Federation/ActivityPub feature packages/backend:test packages/backend Server side specific issue/PR size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants