Convert only simple-array into a real text[]#16283
Open
nabijaczleweli wants to merge 1 commit intomisskey-dev:developfrom
Open
Convert only simple-array into a real text[]#16283nabijaczleweli wants to merge 1 commit intomisskey-dev:developfrom
nabijaczleweli wants to merge 1 commit intomisskey-dev:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16283 +/- ##
===========================================
- Coverage 47.95% 39.80% -8.16%
===========================================
Files 1758 1754 -4
Lines 186664 180295 -6369
Branches 5425 3024 -2401
===========================================
- Hits 89509 71760 -17749
- Misses 97111 108476 +11365
- Partials 44 59 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
There is only one simple-array in the repository, everything else uses
array: true. This can be corrected.Why
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1161#note_16259
Checklist