enhance(frontend): 検索時URLをクエリパラメータ付きのもので置き換えるように#16278
Open
k0range wants to merge 4 commits intomisskey-dev:developfrom
Open
enhance(frontend): 検索時URLをクエリパラメータ付きのもので置き換えるように#16278k0range wants to merge 4 commits intomisskey-dev:developfrom
k0range wants to merge 4 commits intomisskey-dev:developfrom
Conversation
ページ転移を行わずにアドレスバー上や、ウィンドウからコピーできるページのURLを変更することができます。 ページを再描画せずにクエリパラメータを追加したい場合などで利用できます。
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #16278 +/- ##
============================================
- Coverage 42.56% 17.68% -24.89%
============================================
Files 1685 860 -825
Lines 170650 78785 -91865
Branches 4223 1335 -2888
============================================
- Hits 72643 13930 -58713
+ Misses 97546 64849 -32697
+ Partials 461 6 -455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
4ef08fa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nirax.tsにURLを置き換える関数replaceUrl()を追加しました。Why
Resolves #15238
クエリパラメータがあることの認知度向上や、検索結果の共有がやりやすくなるなどの利点があります。
Additional info (optional)
Checklist