enhance(backend): Allow renote of public notes with any visibility#16185
Open
eternal-flame-AD wants to merge 1 commit intomisskey-dev:developfrom
Open
enhance(backend): Allow renote of public notes with any visibility#16185eternal-flame-AD wants to merge 1 commit intomisskey-dev:developfrom
eternal-flame-AD wants to merge 1 commit intomisskey-dev:developfrom
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Contributor
|
このPRによるapi.jsonの差分 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16185 +/- ##
===========================================
- Coverage 45.96% 45.95% -0.01%
===========================================
Files 1740 1740
Lines 177671 177666 -5
Branches 5328 4721 -607
===========================================
- Hits 81659 81652 -7
- Misses 95968 95978 +10
+ Partials 44 36 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hmmm, CI seems to be failing for unrelated reasons, maybe it needs to be re-run? |
KisaragiEffective
requested changes
Jun 13, 2025
Collaborator
KisaragiEffective
left a comment
There was a problem hiding this comment.
I do not agree with this change without proper discussions in the linked issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #12864
Why
See #12864 (comment) , and subsequent discussions.
Additional info (optional)
Checklist