Skip to content

enhance(backend): Allow renote of public notes with any visibility#16185

Open
eternal-flame-AD wants to merge 1 commit intomisskey-dev:developfrom
eternal-flame-AD:renote-public-audience
Open

enhance(backend): Allow renote of public notes with any visibility#16185
eternal-flame-AD wants to merge 1 commit intomisskey-dev:developfrom
eternal-flame-AD:renote-public-audience

Conversation

@eternal-flame-AD
Copy link
Copy Markdown
Contributor

What

Fixes #12864

Why

See #12864 (comment) , and subsequent discussions.

Additional info (optional)

Checklist

  • Read the contribution guide
  • [] Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
@eternal-flame-AD eternal-flame-AD changed the title [WIP] enhance(backend): Allow renote of public notes with any visibility enhance(backend): Allow renote of public notes with any visibility Jun 11, 2025
@github-actions github-actions Bot added the packages/backend Server side specific issue/PR label Jun 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.95%. Comparing base (5680214) to head (0cf68c7).
⚠️ Report is 985 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/NoteCreateService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16185      +/-   ##
===========================================
- Coverage    45.96%   45.95%   -0.01%     
===========================================
  Files         1740     1740              
  Lines       177671   177666       -5     
  Branches      5328     4721     -607     
===========================================
- Hits         81659    81652       -7     
- Misses       95968    95978      +10     
+ Partials        44       36       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eternal-flame-AD
Copy link
Copy Markdown
Contributor Author

Hmmm, CI seems to be failing for unrelated reasons, maybe it needs to be re-run?

@Sayamame-beans Sayamame-beans moved this from Todo to Needs Discussion in [実験中] 管理用 Jun 11, 2025
@Sayamame-beans Sayamame-beans added the 🌌Federation The Federation/ActivityPub feature label Jun 11, 2025
@tai-cha tai-cha added the ☢️Breaking This change breaks compatibility label Jun 11, 2025
Copy link
Copy Markdown
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not agree with this change without proper discussions in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️Breaking This change breaks compatibility 🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR

Projects

Status: Needs Discussion

Development

Successfully merging this pull request may close these issues.

allow quote renotes to be Public where the target post is Unlisted?

4 participants