refactor(frontend): TransitionGroupの動的切り替えをコンポーネントに分離#16122
Open
kakkokari-gtyih wants to merge 18 commits intomisskey-dev:developfrom
Open
refactor(frontend): TransitionGroupの動的切り替えをコンポーネントに分離#16122kakkokari-gtyih wants to merge 18 commits intomisskey-dev:developfrom
kakkokari-gtyih wants to merge 18 commits intomisskey-dev:developfrom
Conversation
…roup or a native element based on the user's animation preference
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16122 +/- ##
============================================
- Coverage 63.65% 14.03% -49.63%
============================================
Files 1160 241 -919
Lines 115616 11356 -104260
Branches 8168 3758 -4410
============================================
- Hits 73598 1594 -72004
+ Misses 39834 7620 -32214
+ Partials 2184 2142 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
独自のコンポーネントが間に挟まることによって可読性が向上した感はあまり感じられないのと、同じく間に追加でコンポーネントが挟まることによるパフォーマンス上のデメリットが気になるわね(ネストが一段深くなることによる子コンポーネントのレンダリングへの影響がどれほど変わるか) |
Contributor
Author
可読性というよりかは書きやすさかもしれないわね(トリッキーな処理を意識しないで良くなるのと、同じロジックを何度も書く必要がなくなる) |
…kokari-gtyih/misskey into fix-dynamic-transition-group
Contributor
Author
|
コンフリクト解消 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1053
TransitionGroupとdivの切り替えを行うロジックをコンポーネントに分離
Why
Additional info (optional)
Checklist