Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #15860 +/- ##
============================================
- Coverage 42.54% 16.11% -26.44%
============================================
Files 1685 812 -873
Lines 170752 72913 -97839
Branches 4222 1341 -2881
============================================
- Hits 72654 11749 -60905
+ Misses 97604 60722 -36882
+ Partials 494 442 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
労力に見合うメリットが無いからやめるかも |
Member
Author
|
text-box-trimという素晴らしいプロパティがあった |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
今まで複数行のテキストをレンダリングしていた個所を洗い出し専用のクラス
_mtを付与する作業が若干面倒(まあ抜けがあったとして大きな問題があるというわけではないけども)※とはいえそこが一行表示なのか複数行表示なのか明示するように改修することは、このPRに関わらずいつかはやらなければならないこと
Why
要素の高さに小数点が含まれると、要素が隣り合ったときに1px分の隙間がレンダリングされてしまうなどのグリッチを引き起こすので、それを防止
高さが小数だとレンダリングパフォーマンスに悪影響を及ぼす可能性もある(未検証)
また、フォントサイズ = 高さという前提があればデザインがしやすくなるほか、環境によってデザインが崩れることを防止できる
Additional info (optional)
Checklist