fix(frontend): 設定マイグレーション周りの修正#15807
Open
kakkokari-gtyih wants to merge 11 commits intomisskey-dev:developfrom
Open
fix(frontend): 設定マイグレーション周りの修正#15807kakkokari-gtyih wants to merge 11 commits intomisskey-dev:developfrom
kakkokari-gtyih wants to merge 11 commits intomisskey-dev:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #15807 +/- ##
============================================
- Coverage 62.86% 13.97% -48.90%
============================================
Files 1150 237 -913
Lines 115224 11273 -103951
Branches 7907 3728 -4179
============================================
- Hits 72439 1575 -70864
+ Misses 40644 7578 -33066
+ Partials 2141 2120 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
アプデ直後の読み込みでimportに失敗した場合に面倒なことになりそうなのと、当該ファイルを分割することによるサイズ削減の効果はあまり無さそうだから今のままで良いかも
説明を読む時間を与えたいから今のままで良いかも? |
Contributor
Author
プロパティ名がminifyされないので結構でかいはず
最低n秒待たすとかはやってもいいかも(それでもPromiseが終わるまでは待ったほうがいい気はする)
Promise.allなのでそのまま続行するはず |
Member
|
あまり変更を行って問題が起きてもアレだからひとまず現在の実装を維持することにします 🙏🏻 |
Contributor
Author
|
やっぱりあったほうがいい気がする
|
Contributor
Author
|
コンフリクト解消 |
Contributor
Author
|
最低5秒は待つようにした |
Contributor
Author
|
コンフリクト解消 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Additional info (optional)
Checklist