tries to extend timeout for deleting user#15747
Draft
anatawa12 wants to merge 4 commits intomisskey-dev:developfrom
Draft
tries to extend timeout for deleting user#15747anatawa12 wants to merge 4 commits intomisskey-dev:developfrom
anatawa12 wants to merge 4 commits intomisskey-dev:developfrom
Conversation
Contributor
|
このPRによるapi.jsonの差分 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15747 +/- ##
===========================================
- Coverage 62.84% 62.83% -0.01%
===========================================
Files 1150 1150
Lines 115224 115260 +36
Branches 7893 7890 -3
===========================================
+ Hits 72407 72421 +14
- Misses 40658 40679 +21
- Partials 2159 2160 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
本来の問題の note 削除部分で extend してなかったので修正 |
anatawa12
commented
Apr 13, 2025
| export async function extendTimeoutQuery(dataSource: DataSource, query: (manager: EntityManager) => Promise<void>): Promise<void> { | ||
| const queryRunner = dataSource.createQueryRunner('master'); | ||
| const manager = dataSource.createEntityManager(queryRunner); | ||
| const extendedTimeout = 1000 * 100; // 100 sec for now. How long should it be? |
Member
Author
There was a problem hiding this comment.
Suggested change
| const extendedTimeout = 1000 * 100; // 100 sec for now. How long should it be? | |
| const extendedTimeout = 0; // infinity |
もし試す方でタイムアウトを無効化する場合はこちらを0にしてください
Contributor
Backend Memory Usage Comparison
|
Member
Author
|
conflict resolved. 試用サーバーからのフィードバック待ちの認識です |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tries to fix #9975
Related #10659
ノート数が多くて削除に時間がかかる実例やちゃんとコネクションプールが作成されるようなものを用意できていないため、どんな副作用があるかが不透明であるため、Draftとしています。
Why
ユーザを削除できないのはプライバシー等的な意味でも問題が発生するため。
Additional info (optional)
Checklist