Skip to content

Use selenium 2 as the default version - #410

Merged
aik099 merged 2 commits into
minkphp:masterfrom
uuf6429:chore/fix-default-selenium-version
Jan 19, 2025
Merged

Use selenium 2 as the default version#410
aik099 merged 2 commits into
minkphp:masterfrom
uuf6429:chore/fix-default-selenium-version

Conversation

@uuf6429

@uuf6429 uuf6429 commented Jan 19, 2025

Copy link
Copy Markdown
Member

I missed this in the original PR. This driver cannot work with Selenium 4 at all, so it makes sense to use a supported default version, if for anything to avoid confusing users.

@codecov

codecov Bot commented Jan 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (4ad4a11) to head (1357fcc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #410   +/-   ##
=========================================
  Coverage     86.21%   86.21%           
  Complexity      185      185           
=========================================
  Files             1        1           
  Lines           515      515           
=========================================
  Hits            444      444           
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099

aik099 commented Jan 19, 2025

Copy link
Copy Markdown
Member

@uuf6429 , inform me once PR is ready (I hope any PR's in non-Draft status are ready for review).

@uuf6429

uuf6429 commented Jan 19, 2025

Copy link
Copy Markdown
Member Author

@aik099 It's ready now.

@aik099
aik099 merged commit 717c5b3 into minkphp:master Jan 19, 2025
@aik099

aik099 commented Jan 19, 2025

Copy link
Copy Markdown
Member

Merged. Thanks @uuf6429 .

@uuf6429
uuf6429 deleted the chore/fix-default-selenium-version branch January 19, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants