Skip "testDragDropOntoHiddenItself" test on Selenium 2 + Firefox - #401
Merged
aik099 merged 2 commits intoNov 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
============================================
- Coverage 90.52% 86.20% -4.32%
- Complexity 180 193 +13
============================================
Files 1 1
Lines 517 551 +34
============================================
+ Hits 468 475 +7
- Misses 49 76 +27 ☔ View full report in Codecov by Sentry. |
aik099
force-pushed
the
selenium2-self-drag-test-exclusion
branch
from
November 11, 2024 10:36
5b6a608 to
9a84262
Compare
uuf6429
reviewed
Nov 12, 2024
uuf6429
reviewed
Nov 12, 2024
Member
|
Other than the two minor comments I left, what about that failing build? I haven't investigated it, but at first look it doesn't sound random. |
uuf6429
approved these changes
Nov 12, 2024
uuf6429
left a comment
Member
There was a problem hiding this comment.
Other than the failing test, this looks fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #391