Skip to content

Correct usage example in the README.md - #386

Merged
aik099 merged 1 commit into
minkphp:masterfrom
aik099:readme-example-fix
Mar 16, 2024
Merged

Correct usage example in the README.md#386
aik099 merged 1 commit into
minkphp:masterfrom
aik099:readme-example-fix

Conversation

@aik099

@aik099 aik099 commented Feb 25, 2024

Copy link
Copy Markdown
Member

The usage example in the README.md file is quite outdated:

  • it has a Selenium\Client class import (likely from Selenium 1 driver), that doesn't exist in this driver
  • it specifies the page URL in place of the WebDriver host URL
  • no page is actually opened
  • the Composer autoload.php file isn't included, which results in a Fatal error

The provided example might actually be working.

@codecov

codecov Bot commented Feb 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (4ca4083) to head (38dc757).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #386   +/-   ##
=========================================
  Coverage     90.19%   90.19%           
  Complexity      168      168           
=========================================
  Files             1        1           
  Lines           469      469           
=========================================
  Hits            423      423           
  Misses           46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099
aik099 force-pushed the readme-example-fix branch from 8ce092a to 38dc757 Compare February 25, 2024 14:15
@aik099
aik099 merged commit a3a5370 into minkphp:master Mar 16, 2024
@aik099
aik099 deleted the readme-example-fix branch March 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant