Fixing window switching on Selenium 3 - #384
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
============================================
+ Coverage 90.19% 90.52% +0.33%
- Complexity 168 180 +12
============================================
Files 1 1
Lines 469 517 +48
============================================
+ Hits 423 468 +45
- Misses 46 49 +3 ☔ View full report in Codecov by Sentry. |
aik099
force-pushed
the
window-test-fix
branch
from
February 24, 2024 12:37
ca5c4e0 to
67bb34e
Compare
aik099
force-pushed
the
window-test-fix
branch
from
February 24, 2024 12:41
67bb34e to
716ac2a
Compare
This was referenced Feb 24, 2024
Merged
mvorisek
reviewed
Feb 24, 2024
mvorisek
reviewed
Feb 24, 2024
uuf6429
approved these changes
Feb 25, 2024
aik099
force-pushed
the
window-test-fix
branch
2 times, most recently
from
March 11, 2024 18:53
ec98133 to
0ed565f
Compare
Member
Author
|
@stof , please review. Ideally please review my other PRs as well: https://github.com/minkphp/MinkSelenium2Driver/pulls/aik099 . |
aik099
force-pushed
the
window-test-fix
branch
2 times, most recently
from
April 10, 2024 07:44
9903ccc to
2a85993
Compare
…now, instead of window handles
aik099
force-pushed
the
window-test-fix
branch
from
October 31, 2024 12:21
3749e26 to
c9a24f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this error from the #383:
Implementation ported from the https://github.com/minkphp/webdriver-classic-driver.
What's included:
getWindowNameandgetWindowNamesmethods to return window names instead of window handles (if the name is empty, then the handle is returned)Related issues:
Session::resetcall driver-testsuite#96