Wait for MinIO to be ready before proceeding with any further tasks. #2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03691ec to
4347da3
Compare
pjuarezd
reviewed
Jun 20, 2024
4347da3 to
8a41a66
Compare
Contributor
ramondeklein
left a comment
There was a problem hiding this comment.
Wouldn't it make more sense that we have a state before provisioning of the user's that is called Waiting for the cluster to become healthy and just run health-checks? When the health-check succeeds, then we start provisioning users.
9a96f03 to
3acde81
Compare
cesnietor
reviewed
Jun 21, 2024
Contributor
cesnietor
left a comment
There was a problem hiding this comment.
@cniackz could you please add more details on the description like the motivation and how e.g. creating users addresses this? cause the title made me think is was just about a message being logged but is doing more than that.
831f841 to
4636e3d
Compare
ramondeklein
requested changes
Jun 21, 2024
4636e3d to
635ef39
Compare
ramondeklein
previously approved these changes
Jun 21, 2024
Contributor
|
PS: Please use descripte PR titles |
635ef39 to
436141f
Compare
shtripat
reviewed
Jun 24, 2024
ramondeklein
previously approved these changes
Jun 24, 2024
babb272 to
15608d3
Compare
Apply suggestions from code review Co-authored-by: Pedro Juarez <[email protected]> Update pkg/controller/main-controller.go Co-authored-by: Shubhendu <[email protected]>
15608d3 to
51663cb
Compare
ramondeklein
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To address #2170
Testing notes:
https://github.com/cniackz/public/wiki/How-to-test-dynamic-status