Skip to content

Adds constants to customize mc help content - #5

Merged
harshavardhana merged 2 commits into
minio:masterfrom
ebozduman:help_customization_historyOnOff
Sep 24, 2019
Merged

harshavardhana merged 2 commits into
minio:masterfrom
ebozduman:help_customization_historyOnOff

Conversation

@ebozduman

Copy link
Copy Markdown

2 more constants to disable/enable history for mc commands that exposes secret-key or password. We have examples like below.

  1. Add MinIO service under "myminio" alias. For security reasons turn off bash history momentarily.
      $ set +o history
      $ {{.HelpName}} myminio http://localhost:9000 minio minio123
      $ set -o history

These will be replaced with:

  1. Add MinIO service under "myminio" alias. For security reasons turn off bash history momentarily.
      {{.DisableHistory}}
      {{.Prompt}} {{.HelpName}} myminio http://localhost:9000 minio minio123
      {{.EnableHistory}}

@harshavardhana
harshavardhana merged commit 735b301 into minio:master Sep 24, 2019
@ebozduman ebozduman changed the title Adds 2 more constants to customize mc help content depending on the OS. Adds constants to customize mc help content Sep 24, 2019
vadmeste pushed a commit to vadmeste/cli that referenced this pull request Sep 28, 2020
…S. (minio#5)

* Adds 2 more constants to customize mc help content depending on the OS.
* Adds missing prompt to Unix style
vadmeste pushed a commit to vadmeste/cli that referenced this pull request Sep 28, 2020
…S. (minio#5)

* Adds 2 more constants to customize mc help content depending on the OS.
* Adds missing prompt to Unix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants