Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

isSameSite should clearly state that the answer may change over time due to PSL changes #11

Description

@erik-anderson

Since the Public Suffix List can change what isSameSite returns, there should at least be a note to developers warning them of that.

Naming it isCurrentlySameSite may be a non-shaming name that also conveys that the answer may change over time.

Activity

  1. mikewest commented on Nov 11, 2025

    @mikewest
    Owner

    Hey Erik! I am more enthusiastic about a note than a name change, but I understand and agree with the concern you're raising. Still, I wonder whether this is a special-enough case to justify explicitly labeling something as potentially temporary? We don't do that for other temporary-yet-potentially-cached things like the user's time zone or language preferences (my brain is fried, so I'm not coming up with more compelling examples, but the platform is full of interesting information on which developers predicate decisions that are also ephemeral in nature).

  2. erik-anderson commented on Nov 18, 2025

    @erik-anderson
    Author

    The sentiment I believe I was hearing from the room was that, for many developers, it's probably not intuitive that this answer can change over time (based on changes to the Public Suffix List). PSL and how it results in different eTLD+1s are, in my experience, not something that is well understood.

    The non-staticness of things like time zones and language preferences is (IMO) much more intuitive. But perhaps there's some other existing, less intuitive examples with a similar risk.

    That said, it's fair to ask if an API name is really the best way to convey this context. An informational note in the spec and/or MDN may be sufficient.

  3. mikewest commented on Nov 19, 2025

    @mikewest
    Owner

    I added a note in whatwg/html@2904ac2 that I hope addresses this. I'll close this out, but if you think the text is insufficient (or you change your mind about the naming issue), leave comments on the PR?

    Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions