add xmake v2.3.6 by waruqi · Pull Request #2941 · microsoft/winget-pkgs

waruqi · 2020-08-07T01:40:00Z

Have you signed the Contributor License Agreement?
Have you checked that there aren't other open pull requests for the same manifest update/change?
Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

wingetbot · 2020-08-07T01:40:02Z

/AzurePipelines run

azure-pipelines · 2020-08-07T01:40:11Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-08-07T01:42:37Z

waruqi The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

wingetbot · 2020-08-07T01:45:16Z

/AzurePipelines run

azure-pipelines · 2020-08-07T01:45:32Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-08-07T01:52:03Z

This submission has moved to manual review.

ghost · 2020-08-07T02:18:20Z

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

perplexityjeff · 2020-08-07T10:34:53Z

I'd suggest to add the switches to the end of the file as well?

Switches:
Silent: /S
SilentWithProgress: /S

wingetbot · 2020-08-07T10:51:30Z

/AzurePipelines run

azure-pipelines · 2020-08-07T10:51:39Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-08-07T10:54:50Z

This submission has moved to manual review.

wingetbot · 2020-08-14T02:41:38Z

/AzurePipelines run

azure-pipelines · 2020-08-14T02:41:48Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-08-14T02:44:18Z

waruqi:
When processing this package, the URL to the installer returned a 404 error or was determined to be invalid.

Please update the URL and hash at your convenience and resubmit your PR.

wingetbot · 2020-08-14T03:09:02Z

/AzurePipelines run

azure-pipelines · 2020-08-14T03:09:11Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-08-14T03:15:48Z

This submission has moved to manual review.

waruqi · 2020-08-14T03:16:35Z

@waruqi I am not an expert on NSIS by far but maybe this change that was made in FileZilla can help you as well. or wait until winget supports using custom exit codes for success.

https://forum.filezilla-project.org/viewtopic.php?t=36679
https://svn.filezilla-project.org/filezilla/FileZilla3/trunk/data/install.nsi.in?r1=6557&r2=6628&pathrev=6628

@perplexityjeff I have fixed it, thanks!

perplexityjeff · 2020-08-14T06:43:27Z

@waruqi I can confirm as well when testing your file that it all works fine, nice!

@denelon, @KevinLaMS I think we are all set to merge?

ghost · 2020-08-14T19:59:14Z

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

waruqi · 2020-08-17T06:30:58Z

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

? What is this problem?

perplexityjeff · 2020-08-17T06:33:14Z

@waruqi, SmartScreen got triggered during installation. I hope that the team can fix this for you and get it merged, I can't help you with this one :(. I see no reason why it would not get fixed tho.

Maybe we can get @KevinLaMS to get a status?

waruqi · 2020-08-17T06:38:41Z

@waruqi, SmartScreen got triggered during installation. I hope that the team can fix this for you and get it merged, I can't help you with this one :(. I see no reason why it would not get fixed tho.

Maybe we can get @KevinLaMS to get a status?

@perplexityjeff Ok, Thanks!

ghost · 2020-08-19T14:08:35Z

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Validation has completed

add xmake v2.3.6

319ca62

waruqi mentioned this pull request Aug 7, 2020

add xmake 2.3.5 #2640

Closed

4 tasks

wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 7, 2020

ghost added the Needs: author feedback label Aug 7, 2020

remove repeat publisher

79fbcd5

ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Aug 7, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 7, 2020

ghost assigned KevinLaMS Aug 7, 2020

ghost removed the Needs: Attention label Aug 7, 2020

KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 7, 2020

ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 7, 2020

add slient switches

7888e5b

ghost removed Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation Needs SmartScreen Investigation labels Aug 7, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 7, 2020

ghost assigned denelon Aug 7, 2020

ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application Needs: Attention labels Aug 14, 2020

wingetbot added the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label Aug 14, 2020

ghost added the Needs: author feedback label Aug 14, 2020

Update 2.3.6.yaml

278ee16

ghost added Needs: Attention and removed Needs: author feedback Error-Installer-Availability The installer was not available to validate (HTTP Issue) labels Aug 14, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 14, 2020

ghost removed the Needs: Attention label Aug 14, 2020

KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 14, 2020

ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 14, 2020

KevinLaMS added the Validation-Completed Validation passed label Aug 19, 2020

ghost approved these changes Aug 19, 2020

View reviewed changes

ghost merged commit 137f366 into microsoft:master Aug 19, 2020

This pull request was closed.

Conversation

waruqi commented Aug 7, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

wingetbot commented Aug 7, 2020

Uh oh!

azure-pipelines Bot commented Aug 7, 2020

Uh oh!

ghost commented Aug 7, 2020

Uh oh!

wingetbot commented Aug 7, 2020

Uh oh!

azure-pipelines Bot commented Aug 7, 2020

Uh oh!

ghost commented Aug 7, 2020

Uh oh!

ghost commented Aug 7, 2020

Uh oh!

perplexityjeff commented Aug 7, 2020

Uh oh!

wingetbot commented Aug 7, 2020

Uh oh!

azure-pipelines Bot commented Aug 7, 2020

Uh oh!

ghost commented Aug 7, 2020

Uh oh!

wingetbot commented Aug 14, 2020

Uh oh!

azure-pipelines Bot commented Aug 14, 2020

Uh oh!

ghost commented Aug 14, 2020

Uh oh!

wingetbot commented Aug 14, 2020

Uh oh!

azure-pipelines Bot commented Aug 14, 2020

Uh oh!

ghost commented Aug 14, 2020

Uh oh!

waruqi commented Aug 14, 2020

Uh oh!

perplexityjeff commented Aug 14, 2020

Uh oh!

ghost commented Aug 14, 2020

Uh oh!

waruqi commented Aug 17, 2020

Uh oh!

perplexityjeff commented Aug 17, 2020

Uh oh!

waruqi commented Aug 17, 2020

Uh oh!

ghost commented Aug 19, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

waruqi commented Aug 7, 2020 •

edited by ghost

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.