Natvis cleanup following the windows-result crate split#2853
Merged
kennykerr merged 7 commits intomicrosoft:masterfrom Feb 17, 2024
Merged
Natvis cleanup following the windows-result crate split#2853kennykerr merged 7 commits intomicrosoft:masterfrom
windows-result crate split#2853kennykerr merged 7 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks Tim, I'll leave #2854 open until this completes. I just need someone a bit more familiar with natvis to looks this over. |
Contributor
Author
|
Thank you, Kenny. I didn't mean to delay a release, and most certainly not an important one. I'd feel more at ease if @ridwanabdillahi could have a look at the "changes" (or relocations). If that doesn't happen in due time feel free to release the crates (without this change) nonetheless. This PR doesn't affect existing clients, and is rather cosmetic in nature to future clients. |
riverar
approved these changes
Feb 16, 2024
Collaborator
riverar
left a comment
There was a problem hiding this comment.
The natvis split looks good to me.
Just noted another problem with our cross-debugger experience, something we'll have to start testing more thoroughly soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on PR 2847 this PR is tying up a few loose ends:
windows-core's windows.natvis into windows-core.nativs and windows-result.natvisThis PR isolates debug visualizers into their respective crates, ensuring that the debugging experience is the same across any combination thereof.
This PR doesn't update the
debugger_visualizertests to validate that the visualizers work in isolation. As I understand, the testing process is destined to change, so I didn't bother. I'll happily rework the test code if that's still a ways off.