Add .cjs to known JavaScript file extensions - #85460
Merged
Merged
Conversation
|
|
ZHAO Jin-Xiang (xiaoxiangmoe)
force-pushed
the
master
branch
from
November 23, 2019 17:12
3d45ff7 to
991ed33
Compare
Matt Bierner (mjbvz)
suggested changes
Nov 26, 2019
| }, | ||
| "fenced_code_block_js": { | ||
| "begin": "(^|\\G)(\\s*)(`{3,}|~{3,})\\s*(?i:(js|jsx|javascript|es6|mjs|\\{\\.js.+?\\})((\\s+|:|\\{)[^`~]*)?$)", | ||
| "begin": "(^|\\G)(\\s*)(`{3,}|~{3,})\\s*(?i:(js|jsx|javascript|es6|mjs|cjs|\\{\\.js.+?\\})((\\s+|:|\\{)[^`~]*)?$)", |
Contributor
There was a problem hiding this comment.
Note that this grammar is generated from https://github.com/microsoft/vscode-markdown-tm-grammar
Make sure this is also updated upstream or else this change will be overwritten when we pull in the next update to this grammar
| function adaptToJavaScript(grammar, replacementScope) { | ||
| grammar.name = 'JavaScript (with React support)'; | ||
| grammar.fileTypes = ['.js', '.jsx', '.es6', '.mjs']; | ||
| grammar.fileTypes = ['.js', '.jsx', '.es6', '.mjs', '.cjs']; |
Contributor
There was a problem hiding this comment.
Make sure to re-build the grammar after changing the build script:
cd extensions/typescript-basics
npm run update-grammars
Contributor
|
Can you please create an issue for this as well. This helps us track what is delivered each milestone |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.cjsto known JavaScript file extensions.Related:
--experimental-modules. https://github.com/nodejs/node/releases/tag/v13.2.0