Skip to content

Add filter to git hook (dev qol) #85159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
João Moreno (joaomoreno) merged 3 commits into from
Nov 29, 2019
Merged

Add filter to git hook (dev qol) #85159

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0180dd5
add filter to git hook
Nov 19, 2019
1fccc8d
update filtering to filter everything coming into the hygiene task
Nov 28, 2019
37c4838
fix missing semicolon
Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update filtering to filter everything coming into the hygiene task
  • Loading branch information
Anthony Dresser
Anthony Dresser committed Nov 28, 2019
commit 1fccc8dc1c07eaa3c1744d05a6238c10c819d0a2
9 changes: 7 additions & 2 deletions build/gulpfile.hygiene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,12 @@ function hygiene(some) {
let input;

if (Array.isArray(some) || typeof some === 'string' || !some) {
input = vfs.src(some || all, { base: '.', follow: true, allowEmpty: true });
const options = { base: '.', follow: true, allowEmpty: true };
if (some) {
input = vfs.src(some, options).pipe(filter(all)) // split this up to not unnecessarily filter all a second time
} else {
input = vfs.src(all, options);
}
} else {
input = some;
}
Expand Down Expand Up @@ -457,7 +462,7 @@ if (require.main === module) {
console.log('Reading git index versions...');

createGitIndexVinyls(some)
.then(vinyls => new Promise((c, e) => hygiene(es.readArray(vinyls).pipe(filter(all)))
.then(vinyls => new Promise((c, e) => hygiene(es.readArray(vinyls))
.on('end', () => c())
.on('error', e)))
.catch(err => {
Expand Down