fix #84080 added cntl-shift-c and cntl-shift-v to terminal

[James Inkster (Grommers00)]

Added functionality to the "secondary:" to include CNTL-SHIFT+C and CNTL-SHIFT+V so both are capable of being used. You can test this out in the terminal to make sure they are functional. I checked keyboard mapping and they appear there as well.

This PR fixes #84080

[James Inkster (Grommers00)]

Will look into this! Thanks for the feedback!

[James Inkster (Grommers00)]

Hi Daniel Imms (@Tyriar) - not sure if I'm doing something wrong.
if (BrowserFeatures.clipboard.readText) { actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(TerminalPasteAction, TerminalPasteAction.ID, TerminalPasteAction.LABEL, { mac: { primary: KeyMod.CtrlCmd | KeyCode.KEY_V }, win: { primary: KeyCode.Ctrl | KeyCode.KEY_V, secondary: [KeyCode.Ctrl | KeyCode.Shift | KeyCode.KEY_V] }, linux: { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_V } }, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Paste into Active Terminal', category); },

But I assume this is what I'm trying to add. When I load "yarn watch"
and run vscode from ".\scripts\code.bat"

The loaded visual studio code doesn't seem to reflect any of my changes...is this because I'm using a windows machine and running through command prompt as per "Building and debugging via the Windows subsystem for Linux (WSL) is currently not supported."

Sorry to bug you! Thanks for all your help!

[Daniel Imms (Tyriar)]

James Inkster (@Grommers00) the problem is probably because there is no longer a primary one, try removing mac and just making that the "primary" one:

primary: ...,
win: { primary: ..., secondary: ... },
linux: { primary: ... }

[Michael J. Ryan (tracker1)]

Would this work?

primary: KeyCode.CtrlCmd | KeyCode.Shift | KeyCode.KEY_C,
win: { secondary: KeyCode.Ctrl | KeyCode.KEY_C },
mac: { secondary: KeyCode.Cmd | KeyCode.KEY_C }

[James Inkster (Grommers00)]

Yes, I think that should work as well.

[Daniel Imms (Tyriar)]

I'm not sure that works but if it did we wouldn't want cmd+shift+c to be bound on mac. I think they all need a primary.

[Daniel Imms (Tyriar)]

Thanks, looks great!