Skip to content

Fix #83940 - #84414

Merged
João Moreno (joaomoreno) merged 10 commits into
microsoft:masterfrom
hadzhiyski:vh/83940-open-with-i18n
Nov 12, 2019
Merged

Fix #83940#84414
João Moreno (joaomoreno) merged 10 commits into
microsoft:masterfrom
hadzhiyski:vh/83940-open-with-i18n

Conversation

@hadzhiyski

Copy link
Copy Markdown
Contributor

Supported languages: de, en, es, fr, hu, it, pt-br, ru

This PR fixes #83940

Supported languages: de, en, es, fr, hu, it, pt-br, ru
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Nov 10, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment thread build/win32/i18n/messages.en.isl Outdated
Co-Authored-By: jaqra <48099350+jaqra@users.noreply.github.com>
@jaqra

Copy link
Copy Markdown

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

@hadzhiyski

Copy link
Copy Markdown
Contributor Author

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

Thanks. I will try to research what is the correct translation for all supported languages

@jaqra

Copy link
Copy Markdown

It is correct. It is my main language. You can also see from

AddContextMenuFiles=Windows Gezgini bağlam menüsüne "%1 İle Aç" eylemini ekle

Comment thread build/win32/i18n/messages.ru.isl Outdated

@joaomoreno João Moreno (joaomoreno) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like jaqra (metiftikci) (@jaqra) mentions, please fix the encoding issues. 👍 Thanks for the PR!

@hadzhiyski

Copy link
Copy Markdown
Contributor Author

Translations are added for all supported languages and the encoding issues are fixed. Please review

@joaomoreno João Moreno (joaomoreno) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vladislav Hadzhiyski (@hadzhiyski) I still see a lot of changes which don't make sense. Are you maybe converting line endings?

@hadzhiyski

Copy link
Copy Markdown
Contributor Author

Is that what you mean? I deleted the empty lines on end of files, because that was the original look of the files. I added them now. Perhaps I do not have proper file formatting settings and I am really sorry about this and I will fix it. It is my first PR in vscode repository.

@joaomoreno

Copy link
Copy Markdown
Contributor

Not yet... Notice here, all these lines are marked as changed, yet there is no reason for you to have changed them. There must still be some line-ending/encoding change:

image

Comment thread build/win32/i18n/messages.de.isl
@joaomoreno João Moreno (joaomoreno) added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Nov 12, 2019
@joaomoreno
João Moreno (joaomoreno) merged commit 72da3e4 into microsoft:master Nov 12, 2019
@joaomoreno

Copy link
Copy Markdown
Contributor

Great job, thanks!

@hadzhiyski

Copy link
Copy Markdown
Contributor Author

Thank you all for the support

@hadzhiyski
Vladislav Hadzhiyski (hadzhiyski) deleted the vh/83940-open-with-i18n branch November 12, 2019 15:27
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

install-update VS Code installation and upgrade system issues windows VS Code on Windows issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Open with Code" context menu is not localized

4 participants