Fixes Web Firefox: dropping a file onto itself navigates the page - #83962
Merged
Conversation
Benjamin Pasero (bpasero)
suggested changes
Nov 5, 2019
Benjamin Pasero (bpasero)
left a comment
Contributor
There was a problem hiding this comment.
Jean Pierre (@jeanp413) thanks, I think this is the right direction, but now thinking more about it, wouldn't the best fix be to prevent default on the workbench container where this event eventually bubbles up? As such I suggest this fix in:
// Prevent default navigation on drop
this._register(addDisposableListener(this.domElement, EventType.DROP, (e) => EventHelper.stop(e, true)));
Jean Pierre (jeanp413)
force-pushed
the
fix-83287
branch
from
November 5, 2019 15:41
76a2c92 to
4efa950
Compare
Contributor
Author
|
Much better. Thanks |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #83287