Add support of relative paths for git.ignoredRepositories - #83466
Merged
Conversation
Wojciech Buczek (Wowol)
force-pushed
the
issue-76892
branch
2 times, most recently
from
October 29, 2019 22:15
3a51078 to
a7c73af
Compare
Wojciech Buczek (Wowol)
force-pushed
the
issue-76892
branch
from
October 29, 2019 22:17
a7c73af to
a9ac61f
Compare
Contributor
Author
|
João Moreno (@joaomoreno) You were right, converting the path into a URI and then getting its fsPath is breaking path on Linux, so I've removed it. Pull request is ready to be merged now :) |
Contributor
Author
|
João Moreno (@joaomoreno) Is there anything wrong with this PR? I'm not sure why it isn't merged yet, and I don't want conflicts to appear in future due to further changes. |
Contributor
|
Thanks! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #76892