Skip to content

Rename "Reveal in Explorer" to "Reveal in Side Bar" on Search result filename context menu - #83418

Merged
roblourens merged 1 commit into
microsoft:masterfrom
gjsjohnmurray:fix-83139
Nov 11, 2019
Merged

Rename "Reveal in Explorer" to "Reveal in Side Bar" on Search result filename context menu#83418
roblourens merged 1 commit into
microsoft:masterfrom
gjsjohnmurray:fix-83139

Conversation

@gjsjohnmurray

Copy link
Copy Markdown
Contributor

This PR fixes #83139 as discussed there. The context menu option on a Search result filename that was previously captioned 'Reveal in Explorer' is now captioned 'Reveal in Side Bar'

@gjsjohnmurray John Murray (gjsjohnmurray) changed the title Resolve https://github.com/microsoft/vscode/issues/83139 Rename "Reveal in Explorer" to "Reveal in Side Bar" on Search result filename context menu Oct 28, 2019
@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

I don't understand the CI failures on windows and darwin. Is there a way to resubmit in case they were transient?

@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

@isidorn

Copy link
Copy Markdown

Sorry for the slow response, I was on vaction.
I am fine with this change. However I would leave it up to roblourens and Jackson Kearl (@JacksonKearl) since they own the search experience.

@roblourens

Copy link
Copy Markdown
Member

FYI João Moreno (@joaomoreno)

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

Fixed by 3bf8e81

@joaomoreno João Moreno (joaomoreno) added bug Issue identified by VS Code Team member as probable bug ux User experience issues and removed bug Issue identified by VS Code Team member as probable bug ux User experience issues labels Nov 21, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ux User experience issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search result 'show in Explorer' shows in side-panel

5 participants