Skip to content

Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks #82757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex Ross (alexr00) merged 6 commits into from
Oct 21, 2019
Merged

Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks #82757

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a9925f
initial
hypercubestart Oct 17, 2019
3e2bc35
initial
hypercubestart Oct 17, 2019
64612c3
fix setting
hypercubestart Oct 17, 2019
5322313
fix ordering
hypercubestart Oct 17, 2019
cdb6d34
resolve changes
hypercubestart Oct 18, 2019
758dde4
revert changes in map.ts
hypercubestart Oct 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
initial
  • Loading branch information
@hypercubestart
hypercubestart committed Oct 18, 2019
commit 3e2bc3524b277e339b48364b09641546d565a05d
2 changes: 1 addition & 1 deletion src/vs/editor/common/config/editorOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3264,7 +3264,7 @@ export const EditorOptions = {
5, 0, 30,
{
markdownDescription: nls.localize('tasksQuickOpenHistory',
"Controls the number of recent items tracked in task quick open dialog.")
"Controls the number of recent items tracked in task quick open dialog.")
}
)),
useTabStops: register(new EditorBooleanOption(
Expand Down
22 changes: 11 additions & 11 deletions src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,18 +1975,18 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
}
return entries;
}), {
placeHolder,
matchOnDescription: true,
onDidTriggerItemButton: context => {
let task = context.item.task;
this.quickInputService.cancel();
if (ContributedTask.is(task)) {
this.customize(task, undefined, true);
} else if (CustomTask.is(task)) {
this.openConfig(task);
placeHolder,
matchOnDescription: true,
onDidTriggerItemButton: context => {
let task = context.item.task;
this.quickInputService.cancel();
if (ContributedTask.is(task)) {
this.customize(task, undefined, true);
} else if (CustomTask.is(task)) {
this.openConfig(task);
}
}
}
});
});
}

private showIgnoredFoldersMessage(): Promise<void> {
Expand Down