Skip to content

Fixed: Image preview should not zoom on first click if unfocused - #82074

Merged
Matt Bierner (mjbvz) merged 15 commits into
microsoft:masterfrom
MartinBrathen:master
Oct 14, 2019
Merged

Fixed: Image preview should not zoom on first click if unfocused#82074
Matt Bierner (mjbvz) merged 15 commits into
microsoft:masterfrom
MartinBrathen:master

Conversation

@MartinBrathen

Copy link
Copy Markdown
Contributor

Matt Bierner (@mjbvz) I believe this should solve issue #81877

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 8, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@MartinBrathen

Copy link
Copy Markdown
Contributor Author

Pressed the "Update branch" button, now test are not passing, will try to fix somehow.

Comment thread extensions/image-preview/media/main.js Outdated
Comment thread extensions/image-preview/media/main.js
Comment thread extensions/image-preview/src/preview.ts
@MartinBrathen

Copy link
Copy Markdown
Contributor Author

I removed an unnecessary state variable.

In this branch I removed the 'mousedown' listener and the usage of message passing as well. Sadly it introduces a bug where the user has to click twice if the image preview is not focused by clicking on the preview. I do not currently know of a way to check how the preview was focused.

@mjbvz

Copy link
Copy Markdown
Contributor

Thanks! Will be in the next insiders build and is scheduled to go out with VS Code 1.40

@MartinBrathen

Copy link
Copy Markdown
Contributor Author

Cool! Thank you :)

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants