Adding git stash drop for issue 76195 - #76342
Conversation
|
This is a fix for issue #76195 |
|
João Moreno (@joaomoreno) should the menu item have "..." since this is an action that results in the drop-down menu to select the stash to drop, not sure about the style here. |
Yeah, that's the usual pattern. |
|
Ok, done. Let me know if there are other changes you recommend. |
|
This is really a great feature. I am looking forward to use this feature in our everyday's workflow. |
Yes! The way I've designed this you can selectively drop a stash. Waiting on João Moreno (@joaomoreno) to approve or request more changes. |
| } | ||
|
|
||
| async dropStash(index?: number): Promise<void> { | ||
| return await this.run(Operation.Stash, () => this.repository.dropStash(index)); |
There was a problem hiding this comment.
Compile error here, since index can be undefined.
| }, | ||
| { | ||
| "command": "git.stashDrop", | ||
| "when": "config.get.enabled && gitOpenRepositoryCount != 0" |
There was a problem hiding this comment.
Typo here: should be git, not get.
| try { | ||
| await this.run(args); | ||
| } | ||
| } catch (err) { |
There was a problem hiding this comment.
There's a syntax error here.
|
There were more issues which I've commented on. But I went ahead and fixed them and merged the PR. Thanks! 🍻 |
No description provided.