Skip to content

Add showIcons and maxSuggestionsToShow settings - #69942

Merged
Johannes Rieken (jrieken) merged 10 commits into
microsoft:masterfrom
svipas:max-suggestions-to-show-and-icons
Mar 7, 2019
Merged

Add showIcons and maxSuggestionsToShow settings#69942
Johannes Rieken (jrieken) merged 10 commits into
microsoft:masterfrom
svipas:max-suggestions-to-show-and-icons

Conversation

@svipas

@svipas Benas Svipas (svipas) commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Comment thread src/vs/editor/common/config/commonEditorConfig.ts Outdated
Comment thread src/vs/editor/common/config/editorOptions.ts
Comment thread src/vs/editor/contrib/suggest/suggestWidget.ts Outdated
Comment thread src/vs/monaco.d.ts
@jrieken

Copy link
Copy Markdown
Contributor

lgtm - I have pushed one more commit that simplifies the applying of styles. Using the toggleClass util. Thanks, this is ready to merge. We might revisit the name of maxSuggestionsToShow, depends on team feedback.

@jrieken
Johannes Rieken (jrieken) merged commit 3190c25 into microsoft:master Mar 7, 2019
@svipas

Copy link
Copy Markdown
Contributor Author

Johannes Rieken (@jrieken) Thank you very much!

@svipas
Benas Svipas (svipas) deleted the max-suggestions-to-show-and-icons branch March 7, 2019 12:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to disable icons and details in suggestions

2 participants