Fix regex warnings from LGTM.com - #66615
Merged
Merged
Conversation
Sandeep Somavarapu (sandy081)
requested a review
from Johannes Rieken (jrieken)
January 17, 2019 15:00
Contributor
|
In the emmet case the original intention was probably for readability, but I'm fine for changing. |
Pine (octref)
approved these changes
Jan 17, 2019
Matt Bierner (mjbvz)
self-requested a review
January 17, 2019 18:26
Benjamin Pasero (bpasero)
requested review from
Pine (octref)
and removed request for
Johannes Rieken (jrieken) and
Pine (octref)
January 18, 2019 11:38
Contributor
|
Down to one in markdown Matt Bierner (@mjbvz) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some regex warning found up on LGTM.com here.
These are mostly due to confusion about regex syntax where separating character classes with a pipe is not needed.
I think this is the correct fix in each case but I am not entirely sure as it's not always obvious whether a pipe was intended to be a member of the class or not.
In particular I am not sure about the emmet extensions.
(Disclaimer: I work for semmle, the company behind LGTM.com)