Allow kill terminal from the terminal context menu - #66535
Merged
Conversation
Daniel Imms (Tyriar)
suggested changes
Jan 16, 2019
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
I actually thought this was already there 😅
Let's add a separator in between clear and kill, then this looks good to me 👍
Author
|
Daniel Imms (@Tyriar) Hey :) |
Daniel Imms (Tyriar)
approved these changes
Jan 24, 2019
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR asaf050!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
Once split terminal panel to multiple terminals, is more effective to allow user to kill a single terminal from the context menu.
In this PR: