Exclude/include commandsToSkipShell instead of butchering user settings file - #66179
Merged
Daniel Imms (Tyriar) merged 8 commits intoJan 8, 2019
Conversation
This was referenced Jan 7, 2019
Daniel Imms (Tyriar)
approved these changes
Jan 8, 2019
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for making this less horrible 😄, will merge when CI passes
Daniel Imms (Tyriar)
added a commit
to microsoft/vscode-docs
that referenced
this pull request
Jan 8, 2019
Contributor
|
Explained new format in docs: microsoft/vscode-docs@f70ff3e |
Just hardcode the command names, it's a soft dep anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19770