Skip to content

Lock on click - #66169

Merged
Sandeep Somavarapu (sandy081) merged 1 commit into
microsoft:masterfrom
YisraelV:lockOnClick
Jan 15, 2019
Merged

Lock on click#66169
Sandeep Somavarapu (sandy081) merged 1 commit into
microsoft:masterfrom
YisraelV:lockOnClick

Conversation

@YisraelV

@YisraelV Yisrael Veller (YisraelV) commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

@isidorn

Isidor Nikolic (isidorn) commented Jan 8, 2019

Copy link
Copy Markdown

Sandeep Somavarapu (@sandy081) Do you want to review this or should I?
I am fine doing this, but you changed a lot of code in the output land thus I thought you might be a better fit for the review.

@sandy081

Sandeep Somavarapu (sandy081) commented Jan 9, 2019

Copy link
Copy Markdown
Member

Isidor Nikolic (@isidorn) Will do.

@sandy081 Sandeep Somavarapu (sandy081) added the outline Source outline view issues label Jan 9, 2019
YisraelV
Yisrael Veller (YisraelV) commented Jan 9, 2019
View reviewed changes
Comment thread src/vs/workbench/parts/output/electron-browser/outputServices.ts Outdated

@YisraelV Yisrael Veller (YisraelV) Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we probably called this function was to resume scrolling. Now we shouldn't call it anymore because scrolling depends only on the lock action state, and the lock state should persist between channel changes.

@YisraelV

Yisrael Veller (YisraelV) commented Jan 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I added some comments in the code review to clarify my intention. Please let me know if it's preferred not to do it.

Sandeep Somavarapu (@sandy081) I now squashed my two commit into 1 since the second one only fixed something I forgot.

@YisraelV
Make smart scroll and lock action work together.
47014f7 
Clicking inside the output panel should set the lock on just as if the
lock icon was clicked. Moving to the last line (with ctrl+end or click)
should unset the lock.
@sandy081

Sandeep Somavarapu (sandy081) commented Jan 15, 2019

Copy link
Copy Markdown
Member

Yisrael Veller (@YisraelV) I liked toggling the lock button while clicking in the panel.

LGTM

@sandy081
Sandeep Somavarapu (sandy081) merged commit 0e6c4b9 into microsoft:master Jan 15, 2019
@YisraelV

Yisrael Veller (YisraelV) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Sandeep Somavarapu (@sandy081). And also Isidor Nikolic (@isidorn) and everyone else who's taken time to review my contributions. Really appreciate the experience and confidence I've gained from this project.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandy081 Sandeep Somavarapu (sandy081) Awaiting requested review from sandy081

Assignees

@sandy081 Sandeep Somavarapu (sandy081)

Labels

outline Source outline view issues

Projects

None yet

Milestone

December/January 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@YisraelV @isidorn @sandy081