Remove StartupWMClass from URL handler desktop file

[Val Enfys (valenfys)]

Fixes #61989

See also #56727 (comment)

[João Moreno (joaomoreno)]

Awesome. Does the URL handling still work without issues?

[Val Enfys (valenfys)]

João Moreno (@joaomoreno) Yep, works fine! I tested with the URL vscode://file/etc/hosts

[João Moreno (joaomoreno)]

Thanks!

[pycontracts]

Doesn't work at all, I am still getting getting the second icon on Gentoo, GNOME 3.30, and removed StartupWMClass.

[pycontracts]

Update: I was able to fix the issue by actually ADDING:

StartupWMClass=code

The fix in the commit obviously is a big bummer! Please revise!

[Val Enfys (valenfys)]

pycontracts are you sure you're on the latest Code version? I'm also using GNOME 3.30 (and Code 1.30.2 with this fix) so not sure why you'd be experiencing the problem but not me. Can you paste each of your .desktop files for Code?

[Rodrigo Saboya (saboya)]

I have the exact same issue, and adding

StartupWMClass=code

also fixed the issue for me. Also using Gentoo.

[Rodrigo Saboya (saboya)]

Arch users also have the same issue, fixed the same way:

https://aur.archlinux.org/packages/visual-studio-code-bin/

[Sven Kayser (SvenKayser)]

Can confirm, adding
StartupWMClass=code
fixes the issue, running Gentoo 17.0/Gnome 3.24/vscode 1.31.0

[João Moreno (joaomoreno)]

davidbailey00 Maybe we gotta rethink this? Can you figure out why this doesn't work for you when StartupWMClass=code is set?

[Val Enfys (valenfys)]

João Moreno (@joaomoreno) Not sure. Maybe it works for Sven Kayser (@SvenKayser) and Rodrigo Saboya (@saboya) since lowercase "code" is treated differently to uppercase "Code"?

I'm running Ubuntu 18.10, Gnome Shell 3.30.2, Code 1.32.3 and it's working correctly for me.

[Rodrigo Saboya (saboya)]

davidbailey00 That would suggest a locale issue, but is there a locale where lowercase "code" is treated the same as "Code"?

Also, I don't think removing StartupWMClass is correct. Not sure how Ubuntu handles this but it's certainly different from Gentoo. What determines a window's WM_Class?

[Rodrigo Saboya (saboya)]

https://github.com/electron/electron/pull/858/files

$ xprop WM_CLASS
WM_CLASS(STRING) = "code", "Code"