Search: Improvements to clear button behavior - #63082
Merged
Merged
Conversation
… cleared and enabled clear button after any input in search form.
|
|
added 2 commits
November 14, 2018 10:51
… to use onDidChange
…of only search inputs
|
great |
roblourens
reviewed
Nov 26, 2018
…r to access onDidChange event. Changed event listeners in SearchView to use onDidChange events.
|
Is there a way to restore the original behavior? I keep around a list of exclusions that I sometimes swap between include/exclude (e.g. tests). |
Author
|
Winston Huang (@WinnieP) Are you saying that you'd prefer the include/exclude boxes to not clear when the clear button is pressed? |
|
Alec Chan (@aechan) Yes, I personally preferred it when those 2 boxes were not cleared when clearing results. |
Author
|
Winston Huang (@WinnieP) I would recommend opening an issue for that then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #62952
Made a few improvements to the behavior of the search clear button based off the suggestions in the above issue.
The clear button now: