Change icon name on Linux for icon theme compatibility

[Jimmy Merrild Krag (beruic)]

This change is made under the assumption that the '-oss' part is removed for final official distribution builds.

The issue it resolves can be read about here: numixproject/numix-core#2964

Fixes #65750

[Microsoft Contribution License Agreements (msftclas)]

All CLA requirements met.

[wmyhen6]

Unable to open

[Jimmy Merrild Krag (beruic)]

wmyhen6 what is it that you are unable to open?
Is it the issue I refer to?
My repository?
Something else?

[Daniel Imms (Tyriar)]

Thanks for the PR but this is not all that would be involved in changing this and it could have knock on effects for some other projects. Seems to me like numix should just add a code icon numixproject/numix-core#2964 (comment)

I opened discussion when I joined the team about changing the command from code to vscode to avoid potential conflicts, but at that point it was already too late. Now we're aligning things with the command name, and there haven't been any conflict issues to my knowledge.

[Jimmy Merrild Krag (beruic)]

Daniel Imms (@Tyriar) I see no reason to rename the command. This PR is only to rename the the icon name in the generated .desktop files.

[Daniel Imms (Tyriar)]

The same concerns exist for the name though, and they turned out not to be a problem. Changing the icon alone would cause work for us and other teams and I don't think it's worth it when numix can just use "code".

[Josh Fogg (Foggalong)]

Daniel Imms (@Tyriar) The point has been touched on in other issues but to recap for here, the Icon=code is too generic to be reasonably covered by an icon theme. Other applications use that icon name as a call for a generic icon representing code, editors, etc. If we make an icon representing VS Code specifically called code.svg then it will show up in other applications when a call for the (generic) icon with that name is made. The solution we (and a few other theme creators) have gone with for now is to make code.svg a link to the generic text editor icon, but it's understandably left the Linux users of VS Code a bit miffed.

[Daniel Imms (Tyriar)]

Other applications use that icon name as a call for a generic icon representing code, editors, etc.

Josh Fogg (@Foggalong) do you have an example of one of these?

[Bilal Elmoussaoui (bilelmoussaoui)]

The new freedesktop standards asks dev's to use a RDNN for the desktop file name and the icon name to avoid this kind of issues. Please don't change the icon to yet an other name and follow the specs.

[Josh Fogg (Foggalong)]

Daniel Imms (@Tyriar) The topic of VS Code's name has come up that many times across that many different Numix repos now that I'll be dammed if I can find the one which had the examples in it. Admittedly I'd imagine it's less of a problem now than when VS Code first came out because other devs will now avoid the generic name to avoid conflict with VSC, but there'll always be some legacy applications which won't switch.

To clarify on what Bilal Elmoussaoui (@bilelmoussaoui) said (because the terminology used wasn't clear to me), this is an example for VS Code of the Freedesktop icon name standard. It ensures that even if too installed applications have the same name, icon name, etc there won't be a conflict in files.

[Bilal Elmoussaoui (bilelmoussaoui)]

For the FreeDesktop specs:

• Appstream files: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html
• Desktop files: https://standards.freedesktop.org/desktop-entry-spec/latest/
• The desktop file names convention: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html#desktop-file-id

[Daniel Imms (Tyriar)]

Sounds good, I opened #65750 to track this. It needs a bit more work though, mostly in our product build. I don't have time to look into it just now though.

[Josh Fogg (Foggalong)]

Daniel Imms (@Tyriar) Thank you so much for looking into this further!

[Daniel Imms (Tyriar)]

João Moreno (@joaomoreno) I think this is ready to go, let me know if you see any problems with it. There's a corresponding commit to distro in the tyriar/62650-linux-icon branch

[João Moreno (joaomoreno)]

If you run a build and everything works OK, then this lgtm.

[Jimmy Merrild Krag (beruic)]

Can anyone determine which is the right solution to the current merge conflict?

[Daniel Imms (Tyriar)]

Jimmy Merrild Krag (@beruic) I'll be merging this today, it will finally happen this milestone 😉