fix(workbench): add preference to disable recently used tasks - #61994
Closed
Kumar Harsh (kumarharsh) wants to merge 1 commit into
Closed
fix(workbench): add preference to disable recently used tasks#61994Kumar Harsh (kumarharsh) wants to merge 1 commit into
Kumar Harsh (kumarharsh) wants to merge 1 commit into
Conversation
Dirk Bäumer (dbaeumer)
requested changes
Oct 30, 2018
Kumar Harsh (kumarharsh)
force-pushed
the
feat/recent-task-pref
branch
from
November 14, 2018 17:17
82e948f to
8264a60
Compare
Kumar Harsh (kumarharsh)
force-pushed
the
feat/recent-task-pref
branch
from
November 14, 2018 20:35
8264a60 to
c12a39d
Compare
Member
|
I am very busy the next couple of days. Needs to wait a little. Sorry for that. |
Contributor
Author
|
Sure, no problem. |
Alex Ross (alexr00)
requested changes
Jun 5, 2019
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
For the setting name, we must make it task instead of tasks because tasks is already used for the tasks themselves. That needs to be changed in both files. You can test that the setting is ok by using it in the settings UI.
I ran task five, four, three, two, and then one.
Order of tasks in insiders:
Order of tasks with this change:
Member
|
Also please resolve the merge conflicts! |
Member
|
Kumar Harsh (@kumarharsh) Thank you for laying the ground-work for this change. The start you made was finished and merged in #82757. |
Contributor
Author
|
Thanks Alex Ross (@alexr00) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30419