Fixed #58159 by triggering a layout refresh to work around xtermjs bug… - #60221
Merged
Daniel Imms (Tyriar) merged 2 commits intoDec 13, 2018
Conversation
… based on Git-Lior's tip
Contributor
|
Thanks Joseph Duchesne (@josephduchesne), this works really great! Sorry about the delay, I was on vacation all November 🌴 |
Contributor
|
Also it looks like it does fix #59000 👌 |
Joseph Duchesne (josephduchesne)
deleted the
fixes-58159-terminal-vanishing-on-font-resize
branch
December 14, 2018 03:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #58159 by triggering a layout refresh to work around xtermjs bug based on Git-Lior's tip.
This might also help with #59000, but I wasn't sure exactly how to reproduce that.
I kept the same HACK warning as the other edit in hopes that when one gets removed, both can be.
Prior to applying this I could reproduce the issue a good percentage of the time, but afterwards I was unable to reproduce this issue. I tested further by switching back to master and I could reproduce the issue again.