Fix #58731 & add test & preserve input for "create new branch" - #58963
Closed
Guy Waldman (guywaldman) wants to merge 3 commits into
Closed
Fix #58731 & add test & preserve input for "create new branch"#58963Guy Waldman (guywaldman) wants to merge 3 commits into
Guy Waldman (guywaldman) wants to merge 3 commits into
Conversation
Contributor
Author
|
Added a commit that adds preserving the input after accepting the "Create new branch" option (as per your comment). Had to change some things (commit description contains details), would appreciate a strict CR to verify that it shouldn't break anything. From my investigation, it appears that prior to the fix programmatically calling |
* When setting items explicitly (i.e. using the `createQuickPick()` API), the `shouldAlwaysShow` field will now also be propagated
* Propagated input from `QuickPick` through `CreateBranchItem` to the `git.branch` command * Entailed changing `.createCommand()` to not prepend the repository when its already the first argument (did not allow to call `CommandCenter` methods with multiple arguments with `repository` set to true in options)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #58731, when explicitly setting items on a
QuickPick(i.e. via thecreateQuickPick()API as opposed toshowQuickPick()with the items as arguments), theshouldAlwaysShowfield was not propagated.This PR resolves this issue and adds a test.