Skip to content

Skip quick picker when there is only one task to select from #47853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Charles Milette (sylveon) wants to merge 4 commits into from
Closed

Skip quick picker when there is only one task to select from #47853

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b39db9d
Skip quick picker when there is only one task to select from
sylveon Apr 13, 2018
0d21442
Make skipping configurable, add skipping logic to terminate tasks
sylveon Apr 20, 2018
55cc264
Add tasks configuration namespace
sylveon Apr 28, 2018
6faa181
Rename tasks configuration namespace to task
sylveon May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename tasks configuration namespace to task
  • Loading branch information
@sylveon
sylveon committed May 31, 2018
commit 6faa181f91e68742cbcfb69555c9b6e0c38acacc
6 changes: 3 additions & 3 deletions src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,7 +1815,7 @@ class TaskService implements ITaskService {
}

private canSkipPicker(): boolean {
return this.configurationService.getValue<any>().tasks.skipPicker;
return this.configurationService.getValue<any>().task.skipPicker;
}

private showQuickPick(tasks: TPromise<Task[]> | Task[], placeHolder: string, defaultEntry?: TaskQuickPickEntry, group: boolean = false, sort: boolean = false): TPromise<Task> {
Expand Down Expand Up @@ -2367,12 +2367,12 @@ registerSingleton(ITaskService, TaskService);
// Register configuration
const configurationRegistry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration);
configurationRegistry.registerConfiguration({
id: 'tasks',
id: 'task',
order: 25,
title: nls.localize('tasksConfigurationTitle', "Tasks"),
type: 'object',
properties: {
'tasks.skipPicker': {
'task.skipPicker': {
'type': 'boolean',
'description': nls.localize('skipTaskPicker', "Controls whether the quick panel is skipped in conditions when there is only one (build, test, etc...) task to pick from."),
'default': false
Expand Down