Change to prevent fakeFireContinued when initiating time-travel #46441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
8484514 to
054bc03
Compare
Collaborator
|
@mrkmarron thanks for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in issue #42384 I have heavily refactored the code to work almost entirely as an extension.
In this implementation clicking the step-back button when in "live" debug mode will launch a time-travel session. However, a
fireFakeContinuedstill occurs and leaves the live session in an ill-defined state. This PR adds a check for these 2 cases and simply suppresses the fake event when needed. This is backward compatible with previous uses and only impacts the TTD specific code paths.