Skip to content

Conversation

@jjyyxx
Copy link
Contributor

@jjyyxx jjyyxx commented Mar 17, 2018

According to microsoft/monaco-editor#766, I made small changes to the code. The message might be null if serializedMessage === 'null' or undefined if the JSON.parse throws a SyntaxError. So the code should check the nullity first.

Monaco editor itself, I think, will not make invalid messages like this. But other message source(like webpack) which is not intended for monaco editor may lead to this error.

@alexdima
Copy link
Member

Thank you!

@alexdima alexdima added this to the March 2018 milestone Mar 26, 2018
@alexdima alexdima merged commit 86b094d into microsoft:master Mar 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants