Ask to add known huge folders to .gitignore, fixes #44304

[Mrigank Krishan (Mrigank11)]

fixes #44304

[Microsoft Contribution License Agreements (msftclas)]

All CLA requirements met.

[João Moreno (joaomoreno)]

There's a lot about this which is suboptimal. The user should know which folders would be added to gitignore. This doesn't check whether node_modules is already in gitignore at all. This should also be done before any large git status even runs; right now, the Repository will still get into a isRepositoryHuge = true state... the user would still have to reload to get out of it, even after adding to gitignore.

[Mrigank Krishan (Mrigank11)]

João Moreno (@joaomoreno) Thanks for the review. I tried to solve the issues you mentioned:

The user should know which folders would be added to gitignore.

done

This doesn't check whether node_modules is already in gitignore at all.

I used the existing checkIgnore method to do that.

This should also be done before any large git status even runs; right now, the Repository will still get into a isRepositoryHuge = true state... the user would still have to reload to get out of it, even after adding to gitignore.

This was solved by saving the .gitignore the in the ignore method because updateModelState was going to be called anyway. So, the repository will be rechecked.

[João Moreno (joaomoreno)]

This was solved by saving the .gitignore the in the ignore method because updateModelState was going to be called anyway. So, the repository will be rechecked.

This is not true. The repository will be in a isRepositoryHuge state, which force the user to reload the window. Give it a try.

[Mrigank Krishan (Mrigank11)]

If the user presses 'Yes' to the prompt, .gitignore will be saved and updateModelState will be called, so the user won't have to reload the window as updateModelState will update the repo state i.e. isRepositoryHuge will be calculated again (#1).

So, the only case I'm missing is 'when the user modifies .gitignore manually' (right?). How about we use onFSChange to monitor .gitignore (only when isRepositoryHuge is true) and call updateModelState if it changes?